WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@connortsui20
Copy link
Contributor

Removes lance from the SQL remote benchmarks on S3 and cleaned up some commands.

Removes lance from the SQL remote benchmarks on S3
and cleaned up some commands.

Signed-off-by: Connor Tsui <[email protected]>
@connortsui20 connortsui20 enabled auto-merge (squash) December 29, 2025 11:42
@connortsui20
Copy link
Contributor Author

I also just realized that the lance compression benchmark was not carried over from the previous implementation. If someone could take a look at this (bring back the old code and use it in the new benchmarking infra), I think that that will finally unblock all CI from crashing.

Format::Lance => todo!(),

@connortsui20 connortsui20 merged commit a4368bf into develop Dec 29, 2025
48 checks passed
@connortsui20 connortsui20 deleted the ct/fix-ci-sql-remote branch December 29, 2025 11:50
@codecov
Copy link

codecov bot commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.94%. Comparing base (dde9c0b) to head (5d9b242).
⚠️ Report is 1 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants