feat: add natsLeaf configuration with TLS and extra volumes support #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new consolidated natsLeaf configuration block that includes: - All NATS-related settings (image, address, ports, domain, credentials) - TLS configuration with ca, cert, and key path options - Extra volumes and volume mounts for the NATS leaf container The existing top-level NATS fields are deprecated but still functional for backwards compatibility. The new natsLeaf fields take precedence. This allows users to: 1. Mount custom TLS certificates via extraVolumes/extraVolumeMounts 2. Configure NATS leaf TLS by specifying paths to the mounted certs 3. Consolidate all NATS leaf configuration in one place Signed-off-by: Gabber235 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new consolidated natsLeaf configuration block that includes:
The existing top-level NATS fields are deprecated but still functional for backwards compatibility. The new natsLeaf fields take precedence.
This allows users to:
Feature or Problem
When connecting wasmCloud hosts to a NATS server that uses TLS with self-signed or private CA certificates, users previously had no way to configure the NATS leaf sidecar to trust the CA. This resulted in
certificate signed by unknown authorityerrors when connecting to TLS-enabled NATS clusters.Additionally, NATS-related configuration was scattered across multiple top-level fields (
natsLeafImage,secretName,leafNodeDomain,natsAddress,natsClientPort,natsLeafnodePort,jetstreamDomain), making it harder to understand and configure.Related Issues
None
Release Information
Next release
Consumer Impact
Low impact - This is a backwards-compatible change. Existing configurations using the top-level NATS fields will continue to work. Users are encouraged to migrate to the new
natsLeafblock for new deployments.New
natsLeaffields take precedence over the deprecated top-level fields when both are specified.Testing
Unit Test(s)
Existing unit tests pass. No new unit tests were added.
Acceptance or Integration
No changes to acceptance or integration tests.
Manual Verification
cargo buildcargo check- completed successfullycargo test- all tests passednats.confConfigMap includes the TLS block with correct paths