-
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(expect-webdriverio): add toHaveLocalStorageItem matcher #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(expect-webdriverio): add toHaveLocalStorageItem matcher #1900
Conversation
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and sorry for the delayed review. One request, can we ipdate the API docs: https://github.com/webdriverio/expect-webdriverio/blob/main/docs/API.md
7589af9 to
17b882d
Compare
|
Thanks for your review! |
|
@NaamuKim mhm 🤔 seems like some tests are failing:
|
|
@christian-bromann I added types to matchers, can you rerun the tests? |
christian-bromann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, thanks a lot 👍
|
@NaamuKim it seems like there is still a valid test error: |
What I do
Added tests with the toHaveLocalStorageItem function
Why this function is needed
before
after
If you need anything else, let me know and I'll get it implemented quickly.
If this API is okay, I'll also add a PR for Session storage.