WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@Def3nder
Copy link
Contributor

Hi @Aircoookie,

I added the custom configurations (like LEDPIN or WS2801 and APA102) to the environments so that we get all configured in the PIO and the users can build everything like distributed in the releases.

Def3nder and others added 30 commits November 5, 2019 15:55
When adding an RGBW device to Alexa and then selecting a white color tone, Alexa will send CT values to the device. Having a warm white or cold white strip should use 100% of that strip and then add the RGB colors to get either a warmer color or a colder one.
Added IR remote with 40 keys to use with RGBW stripes.
...not implemented for ESP32 yet
ESP32 Solid RGBW defines

moved from env:esp32dev to env:esp32
ESP32 Solid RGBW defines
Update readme.md
To turn off IR remote use "0" in the settings, use 1 to 4 for different IR remote types.
adapt the logic to use CW and WW for different CT-values
Changed code from #define WLED_DISABLE_ANALOG_LEDS to #define WLED_USE_ANALOG_LEDS
NightLight used to brighten the light combined with fading from the actual (primary) color to the secondary color
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS

Corrected list-item indents (readme.md)

updated to match upstream master (briLast in wled00.ino)
RLYPIN definition dependant on WLED_USE_ANALOG_LEDS

Fixed headline and corrected list-item indents (readme.md)

updated to match upstream master (briLast in wled00.ino)
@fishbone-git
Copy link
Contributor

As a broder "solution" why not expand the platformio_override example to have all of the disable, enable, pin_option flags so that it's a one-file point for users to be able to tweak the build for the interface-level customizations? It already has the disables, but LEDPIN, IR_PIN, BTN_PIN, RLYMDE, etc can be added

@Def3nder
Copy link
Contributor Author

like this ?

@fishbone-git
Copy link
Contributor

i would go with copying the comments too so it's clear what each means. so, if all you want to do it make WLED work with your favourite flavour of ESP board and breakout, then you can follow lots of online how-tos for setting up platformIO in various IDEs and then just make a platformio_override with your tweaks. At least until any of these are configurable in a UI.

@Aircoookie
Copy link
Member

Hmm does anybody know how to exclude some environments from travis?
I really like this PR but ideally i'd like travis to only build the d1_mini, esp32_dev, esp01 and esp01_m environments so that it doesn't take 15 minutes, but only 5.

default_envs is ignored by CI as it seems...

@fishbone-git
Copy link
Contributor

perhaps change the travis.yaml to use platformio run instead of platformio ci in the script section. the run command follows platformio.ini (and you'll need to change the platformio.ini to uncomment the release build line). Travis does allow some custom files, but I've used this for a secrets file so don't know if platformio.ini is also a possible option.

@fishbone-git
Copy link
Contributor

ah...something like this in travis.yml:
before_install:

  • mv travis_platformio.ini platformio.ini

The residual risk being an issue in the platformio.ini file for other builds or forgetting to sync up changes in the common sections.

@Def3nder
Copy link
Contributor Author

...unfortunately I cannot compile with -D DEBUG_ESP_CORE enabled 😢
This does lead to errors in debug.h that I just cannot resolve.

...I'm just trying an expplicit "include" of environments in Travis.Ci ...

@Aircoookie
Copy link
Member

Awesome, thanks!
The debug not working is unfortunate, but I don't think it is a major issue for now, we can look into it later.

Ready for merge?

@Def3nder
Copy link
Contributor Author

DEBUG is building now, but the "include" in the YAML did not work 😢

but: ready to merge.

Will have a closer look into How to only compile specific builds with Travis.CI ...

@Aircoookie
Copy link
Member

One solution would be to have a platformio_travis.ini file that contains just the four envs. I don't really like that approach though because it essentially duplicates the environments and any change to the regular platformio.ini would also need to be mirrored there. There has to be a better solution 😅

@Aircoookie Aircoookie merged commit 480e7f5 into wled:master Feb 28, 2020
# This reduces the OTA size with ~45KB, so it's especially useful on low memory boards (512k/1m).
# ------------------------------------------------------------------------------
build_flags = -g -w -DMQTT_MAX_PACKET_SIZE=1024 -DPIO_FRAMEWORK_ARDUINO_LWIP2_HIGHER_BANDWIDTH
build_flags = -g -w -DMQTT_MAX_PACKET_SIZE=1024 -DPIO_FRAMEWORK_ARDUINO_LWIP_HIGHER_BANDWIDTH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intentional ? Also maybe it would be better to try this: #732 (comment)

@Def3nder Def3nder deleted the refactorPIO branch March 2, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants