TopEdits: fix wikitext output for top projects and simplify queries #594
+12
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MusikAnimal
force-pushed
the
top-projects
branch
from
553bb9e to
8db0a1d
Compare
I believe I even requested to combine into one query, but inadvertently this put it in the API output as a serialized JSON string. That could be fixed, but this wasn't intended to be there to begin with. Also, combining the queries is only applicable when there is one page of results, which is usually only the case for less prolific users - in which case doing a separate query is negligible. So this just simplifies things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I even requested to combine into one query, but inadvertently this put it in the API output as a serialized JSON string. That could be fixed, but this wasn't intended to be there to begin with. Also, combining the queries is only applicable when there is one page of results, which is usually only the case for less prolific users - in which case doing a separate query is negligible. So this just simplifies things.