WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@mkcp
Copy link
Contributor

@mkcp mkcp commented Nov 14, 2025

Description

WIP: Add reference documentation for package values and templating.

Related Issue

Relates to #3946

Checklist before merging

@mkcp mkcp self-assigned this Nov 14, 2025
@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 068c56d
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6917a6cdaf83610008e79c1e
😎 Deploy Preview https://deploy-preview-4368--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mkcp mkcp added the documentation 📘 Improvements or additions to documentation label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mkcp added 2 commits November 14, 2025 12:52
…em rather than duplicating the same content

Signed-off-by: Kit Patella <[email protected]>
@mkcp mkcp moved this to In progress in Zarf Nov 14, 2025
mkcp added 5 commits November 14, 2025 12:56
Signed-off-by: Kit Patella <[email protected]>
…nd config file imports and --set-values

Signed-off-by: Kit Patella <[email protected]>
@mkcp mkcp changed the title docs(values,templating): add reference pages for package values and templating docs(values,templating): add reference and best practices pages for package values and templating Nov 14, 2025
@mkcp mkcp changed the title docs(values,templating): add reference and best practices pages for package values and templating docs(values,templating): add reference and best practices pages Nov 14, 2025
@mkcp mkcp marked this pull request as ready for review November 14, 2025 22:13
@mkcp mkcp requested review from a team as code owners November 14, 2025 22:13
Copy link
Contributor

@a1994sc a1994sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkcp mkcp added this pull request to the merge queue Nov 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2025

See the [Templating Reference](/ref/templating/) for complete function documentation.

## Avoid Sensitive Data in Values Files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this is good advice but I do think it is worth calling out that values files will be the primary mechanism for orchestrating sensitive values. Given the declarative delivery model - all secrets have to originate from somewhere.

It will be important for sunsetting zarf variables as it will provide a way to break these out of zarf config files.

We may want to delineate between sensitive values defaults getting "baked" into the package - for which you had a few good examples of different environment overrides that would align to that story telling.


## Common Errors and Solutions

### Template Parse Errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I like that we are making errors in docs discoverable.

targetPath: ".config.database.host" # Takes priority
```

#### Mapping All Values
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we may want to refine this section at some point to help users understand the best practices for building a package with values files that aligns to broader zarf hardening goals.

said another way - I think we should encourage using sourcePath/targetPath as a best practice for package hardening.


:::

Zarf supports Go template syntax and `text/template` engine with powerful features including control flow and functions. Zarf includes the full library of [Sprig functions](http://masterminds.github.io/sprig/) and some builtins for dynamic configuration in manifests, files, and actions. This powerful templating system enables complex transformations, conditional logic, and data manipulation beyond simple string substitution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a good place to identify what is different between zarf templating and helm templating.

Copy link
Member

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving comments on the review so far, I'll aim to do a review on the ref section at another point

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Across this PR we reference zarf package inspect, zarf dev inspect and using the values schema however none of these features are merged into Zarf as of yet. IMO we should wait until a feature is merged before documenting it


## Provide Defaults for Optional Values

Use the `default` function to provide fallback values:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While defaults are generally a good practice, I don't think they really make sense in the context of Zarf since we always validate that there is a value for template. I could be missing scenarios but AFAIK there is no way for the default to come into play


## Leverage Templating Functions

Use [functions](/ref/templating/) for dynamic configuration:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to ref/templating/#template-functions

Comment on lines +227 to +237
data:
# Numbers must be strings in ConfigMaps
port: {{ .Values.app.port | toString | quote }}
replicas: {{ .Values.app.replicas | toString | quote }}

# Booleans to strings
debug: {{ .Values.app.debug | toString | quote }}

# ❌ RISKY: Type mismatch errors
data:
port: {{ .Values.app.port }} # May fail if port is a number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers don't have to be strings in configmaps, Kubernetes will store either

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on generalizing the example a bit then, like "explicit type conversion may be necessary?"


## Handle Missing Values Gracefully

Protect against missing or nil values:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this advice makes sense in the context of Zarf, the "good" example will still fail if .values.monitoring.enabled is not set

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, I don't like encouraging conditional blocks like this either. Removed in latest

Comment on lines +339 to +348
**Solution:**
```yaml
# Use default for optional values
value: {{ .Values.app.missing | default "fallback" }}

# Or check if exists first
{{- if .Values.app.missing }}
value: {{ .Values.app.missing }}
{{- end }}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these solutions would not solve the error.


### Quoting Problems

**Problem:** YAML parsing fails with boolean-like strings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand why we would use the quote function at times, we wouldn't want a type to be interpreted as the incorrect type. Are there situations where YAML parsing would fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a specific yaml spec version where this was a problem, I don't know if this specifically affects Zarf though. This is probably covered under the more general guidance to quote strings.

@mkcp mkcp moved this from In progress to Next in Zarf Dec 2, 2025
@brandtkeller brandtkeller added this to the v0.67.1 Release milestone Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📘 Improvements or additions to documentation

Projects

Status: Next

Development

Successfully merging this pull request may close these issues.

5 participants