WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@brandtkeller
Copy link
Member

Description

This change modifies the stance zarf takes when performing package verification on zarf package deploy.

Verification will be attempted if available - but only enforced when --verify is specified.

Related Issue

Fixes #4048

Checklist before merging

@brandtkeller brandtkeller self-assigned this Dec 9, 2025
@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit df83f38
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/693b4d4e04c936000754b3a8

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 38.91626% with 124 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/package.go 22.62% 106 Missing ⚠️
src/pkg/packager/layout/package.go 51.85% 12 Missing and 1 partial ⚠️
src/cmd/initialize.go 16.66% 5 Missing ⚠️
Files with missing lines Coverage Δ
src/api/v1alpha1/package.go 32.55% <ø> (ø)
src/cmd/root.go 33.69% <100.00%> (ø)
src/cmd/viper.go 54.44% <ø> (ø)
src/pkg/packager/create.go 56.32% <100.00%> (-0.50%) ⬇️
src/pkg/packager/load.go 64.70% <100.00%> (+0.23%) ⬆️
src/pkg/packager/pull.go 48.43% <100.00%> (+0.26%) ⬆️
src/cmd/initialize.go 27.64% <16.66%> (ø)
src/pkg/packager/layout/package.go 57.50% <51.85%> (+0.28%) ⬆️
src/cmd/package.go 38.16% <22.62%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Make signature validation logic opt-in

2 participants