feat: add careers page back #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace existing content with a new layout featuring Product Designer and Brand Designer roles - Add CareersEmailNote component for direct email applications - Remove outdated images and components related to previous job postings - Update English and Chinese translations for careers section
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the careers section to use dedicated, statically generated pages for each role (Product Designer and Brand Designer), with improved localization and a modernized UI for open roles. It replaces the old dynamic
[id]-based job pages with explicit, role-specific files, introduces new MDX content for both English and Chinese, and adds reusable components for listing and displaying open roles. The changes streamline the codebase, enhance clarity for applicants, and improve SEO and Open Graph support.Careers section architecture and UI modernization:
[id]/page.tsx) and replaced it with statically generated, role-specific pages forproduct-designerandbrand-designer, each with localized MDX content and metadata generation. (app/[locale]/careers/[id]/page.tsxL1-L44, app/[locale]/careers/product-designer/page.tsxR1-R27, app/[locale]/careers/brand-designer/page.tsxR1-R27, app/[locale]/careers/brand-designer/page.en.mdxR1-R73, app/[locale]/careers/product-designer/page.en.mdxR1-R72, app/[locale]/careers/product-designer/page.zh-CN.mdxR1-R71, app/[locale]/careers/brand-designer/page.zh-CN.mdxR1-R74)page.en.mdx,page.zh-CN.mdx) to use new components for open roles, removing old position/benefits logic and introducing a modern UI withOpenRolesHeader,RolesList, andRoleCard. (app/[locale]/careers/page.en.mdxL1-R26, app/[locale]/careers/page.zh-CN.mdxL1-R28, [1] [2]Localization and content improvements:
CareersEmailNotecomponent. (components/mdx/Careers.tsxR1-R98, app/[locale]/careers/page.zh-CN.mdxL1-R28)SEO and Open Graph enhancements:
Componentization and code reuse:
OpenRolesHeader,RolesList,RoleCard,CareersEmailNote) tocomponents/mdx/Careers.tsxfor consistent display and easier maintenance of open roles across locales. [1] [2]File organization and cleanup:
Let me know if you want to walk through how the new components work or how the static generation improves performance and SEO!