Updates to get ev3-kernel to compile with 6.12.60 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request updates the ev3-kernel codebase to achieve compatibility with kernel version 6.12.60. The changes focus on dependency management, deprecated API replacement, and build configuration adjustments.
Key Changes:
- Migrated the lego-linux-drivers submodule to a new upstream repository (project516) and updated to the latest commit
- Replaced deprecated
gpio_request_onewith the modern two-stepgpio_request+gpio_direction_outputpattern - Modified the Debian package build process to skip dependency checks for streamlined builds
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .gitmodules | Updates submodule URL to point to new upstream repository (project516/lego-linux-drivers) |
| drivers/lego | Updates submodule commit reference to latest version from new upstream |
| arch/arm/mach-davinci/legoev3-fiq.c | Replaces deprecated GPIO API with modern two-step initialization pattern |
| scripts/Makefile.package | Adds -d flag to dpkg-buildpackage to disable build dependency checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Project516
pushed a commit
that referenced
this pull request
Dec 18, 2025
[ Upstream commit 163e5f2b96632b7fb2eaa965562aca0dbdf9f996 ]
When using perf record with the `--overwrite` option, a segmentation fault
occurs if an event fails to open. For example:
perf record -e cycles-ct -F 1000 -a --overwrite
Error:
cycles-ct:H: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'
perf: Segmentation fault
#0 0x6466b6 in dump_stack debug.c:366
#1 0x646729 in sighandler_dump_stack debug.c:378
#2 0x453fd1 in sigsegv_handler builtin-record.c:722
#3 0x7f8454e65090 in __restore_rt libc-2.32.so[54090]
#4 0x6c5671 in __perf_event__synthesize_id_index synthetic-events.c:1862
#5 0x6c5ac0 in perf_event__synthesize_id_index synthetic-events.c:1943
ev3dev#6 0x458090 in record__synthesize builtin-record.c:2075
ev3dev#7 0x45a85a in __cmd_record builtin-record.c:2888
ev3dev#8 0x45deb6 in cmd_record builtin-record.c:4374
ev3dev#9 0x4e5e33 in run_builtin perf.c:349
ev3dev#10 0x4e60bf in handle_internal_command perf.c:401
ev3dev#11 0x4e6215 in run_argv perf.c:448
ev3dev#12 0x4e653a in main perf.c:555
ev3dev#13 0x7f8454e4fa72 in __libc_start_main libc-2.32.so[3ea72]
ev3dev#14 0x43a3ee in _start ??:0
The --overwrite option implies --tail-synthesize, which collects non-sample
events reflecting the system status when recording finishes. However, when
evsel opening fails (e.g., unsupported event 'cycles-ct'), session->evlist
is not initialized and remains NULL. The code unconditionally calls
record__synthesize() in the error path, which iterates through the NULL
evlist pointer and causes a segfault.
To fix it, move the record__synthesize() call inside the error check block, so
it's only called when there was no error during recording, ensuring that evlist
is properly initialized.
Fixes: 4ea648a ("perf record: Add --tail-synthesize option")
Signed-off-by: Shuai Xue <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates related to submodule management, GPIO initialization, and packaging scripts. The most significant changes are grouped below:
Submodule and Dependency Updates:
drivers/legosubmodule in.gitmodulesto point toproject516/lego-linux-driversinstead of the previousev3devrepository.drivers/legosubmodule to a new commit (bec2d381...) to reflect the latest changes from the new upstream.Platform Device Initialization:
legoev3_fiq_probe(arch/arm/mach-davinci/legoev3-fiq.c) to usegpio_requestfollowed by an explicit call togpio_direction_output, improving clarity and compatibility.Build and Packaging:
bindeb-pkgbuild rule inscripts/Makefile.packageto pass the-dflag todpkg-buildpackage, which disables checking of build dependencies, potentially streamlining package builds in certain environments.