extensions: gxlimg: Update repo URL #8944
Conversation
WalkthroughThis pull request updates the source repository for the gxlimg fetch step from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
github-actions
bot
added
size/small
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
extensions/gxlimg.sh(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.
🧬 Code graph analysis (1)
extensions/gxlimg.sh (1)
lib/functions/general/git.sh (1)
fetch_from_repo(80-300)
🔇 Additional comments (1)
extensions/gxlimg.sh (1)
4-5: No lingering references to the fork found—verification complete.Confirmed that the codebase contains no references to
retro98boy/gxlimg. The file correctly uses the officialrepk/gxlimgrepository via${GITHUB_SOURCE}. Otherretro98boyreferences in the codebase are legitimate copyright attributions, maintainer names, and contributions to unrelated projects (e.g., amlogic-fip-blobs).
| # Branch: master, Commit date: Nov 10, 2025 (please update when updating commit ref) | ||
| fetch_from_repo "${GITHUB_SOURCE}/repk/gxlimg" "gxlimg" "commit:37a3ea072ca81bb3872441a09fe758340fd67dcb" |
There was a problem hiding this comment.
🧩 Analysis chain
Verify the commit hash exists in repk/gxlimg and includes the upstream fix.
The PR reverts to the official repk/gxlimg repository, which is appropriate given that upstream PR #26 is now merged. However, the commit hash needs validation to ensure it includes the bl3x handling fix mentioned in the PR objectives.
🏁 Script executed:
#!/bin/bash
# Description: Verify the commit hash exists in repk/gxlimg and contains the bl3x fix
# Expected: Commit 37a3ea072ca81bb3872441a09fe758340fd67dcb exists in repk/gxlimg repo
# and includes changes related to bl3x handling
# Check if commit exists in the official repk/gxlimg repository
curl -s "https://api.github.com/repos/repk/gxlimg/commits/37a3ea072ca81bb3872441a09fe758340fd67dcb" \
| jq '{sha: .sha, message: .commit.message, author: .commit.author.name, date: .commit.author.date}'Length of output: 147
🏁 Script executed:
#!/bin/bash
# Get details about what files/changes are in this commit
curl -s "https://api.github.com/repos/repk/gxlimg/commits/37a3ea072ca81bb3872441a09fe758340fd67dcb" \
| jq '.files[] | {filename: .filename, status: .status, additions: .additions, deletions: .deletions, patch: .patch}'Length of output: 642
🏁 Script executed:
#!/bin/bash
# Search codebase for references to retro98boy/gxlimg
rg -n "retro98boy" --type sh --type bashLength of output: 28
🏁 Script executed:
#!/bin/bash
# Search codebase for references to retro98boy
rg -n "retro98boy"Length of output: 2592
🏁 Script executed:
#!/bin/bash
# Get info about recent commits in repk/gxlimg to find the actual bl3x fix
curl -s "https://api.github.com/repos/repk/gxlimg/commits?per_page=20" \
| jq '.[] | {sha: .sha[0:12], message: .commit.message, date: .commit.author.date, author: .commit.author.name}' | head -60Length of output: 4925
Correct the commit hash and date - current commit is cleanup code, not the bl3x fix.
The commit date in the comment (Nov 10, 2025) does not match the actual commit date (Oct 3, 2025 — a 37-day discrepancy). Additionally, commit 37a3ea0 ("Remove topad") is cleanup code that removes an unused field; it is not the bl3x handling fix mentioned in the PR objectives.
The actual bl3x fix appears to be commit f157d7b ("amlsblk: Don't assume topad is aligned to file block") from Sep 29, 2025, which contains the bl3x-related padding bug corrections. Verify and use the correct commit hash.
🤖 Prompt for AI Agents
In extensions/gxlimg.sh around lines 4 to 5, the script references commit
37a3ea072ca81bb3872441a09fe758340fd67dcb with a comment date of Nov 10, 2025,
but that commit is a cleanup ("Remove topad") and the date is incorrect; update
the fetch_from_repo call to use the correct commit that contains the bl3x fix
(f157d7b, commit message "amlsblk: Don't assume topad is aligned to file block")
and set the comment date to the actual commit date (Sep 29, 2025), verifying the
hash against the upstream repo before changing the line.
|
Hey @retro98boy I recently noticed some unrelated meson64 boards pulling those due to being in meson64_common. Could we maybe move it to the specific family/boards that require it? |
Sure, I'll submit the PR tomorrow. |
|
✅ This PR has been reviewed and approved — all set for merge! |
3 participants
Description
Because the previous version of repk/gxlimg had some issues when handling bl3x, I forked the repository and made a simple fix. The implementation used in extensions/gxlimg.sh is also mine.
After this PR is merged, the fix in my repository becomes meaningless, so the URL can be switched to repk/gxlimg.
How Has This Been Tested?
./compile.sh BOARD=cainiao-cniot-core BRANCH=current RELEASE=noble, then update U-Boot and testSummary by CodeRabbit