WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

extensions: gxlimg: Update repo URL #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorpecovnik merged 1 commit into from
Nov 16, 2025
Merged

extensions: gxlimg: Update repo URL #8944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/gxlimg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#!/usr/bin/env bash

function fetch_sources_tools__gxlimg() {
fetch_from_repo "${GITHUB_SOURCE}/retro98boy/gxlimg" "gxlimg" "commit:fde6a3dd0e13875a5b219389c0a6137616eaebdb"
# Branch: master, Commit date: Nov 10, 2025 (please update when updating commit ref)
fetch_from_repo "${GITHUB_SOURCE}/repk/gxlimg" "gxlimg" "commit:37a3ea072ca81bb3872441a09fe758340fd67dcb"
Comment on lines +4 to +5
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

Verify the commit hash exists in repk/gxlimg and includes the upstream fix.

The PR reverts to the official repk/gxlimg repository, which is appropriate given that upstream PR #26 is now merged. However, the commit hash needs validation to ensure it includes the bl3x handling fix mentioned in the PR objectives.

🏁 Script executed:

#!/bin/bash
# Description: Verify the commit hash exists in repk/gxlimg and contains the bl3x fix
# Expected: Commit 37a3ea072ca81bb3872441a09fe758340fd67dcb exists in repk/gxlimg repo
#           and includes changes related to bl3x handling

# Check if commit exists in the official repk/gxlimg repository
curl -s "https://api.github.com/repos/repk/gxlimg/commits/37a3ea072ca81bb3872441a09fe758340fd67dcb" \
  | jq '{sha: .sha, message: .commit.message, author: .commit.author.name, date: .commit.author.date}'

Length of output: 147

🏁 Script executed:

#!/bin/bash
# Get details about what files/changes are in this commit
curl -s "https://api.github.com/repos/repk/gxlimg/commits/37a3ea072ca81bb3872441a09fe758340fd67dcb" \
  | jq '.files[] | {filename: .filename, status: .status, additions: .additions, deletions: .deletions, patch: .patch}'

Length of output: 642

🏁 Script executed:

#!/bin/bash
# Search codebase for references to retro98boy/gxlimg
rg -n "retro98boy" --type sh --type bash

Length of output: 28

🏁 Script executed:

#!/bin/bash
# Search codebase for references to retro98boy
rg -n "retro98boy"

Length of output: 2592

🏁 Script executed:

#!/bin/bash
# Get info about recent commits in repk/gxlimg to find the actual bl3x fix
curl -s "https://api.github.com/repos/repk/gxlimg/commits?per_page=20" \
  | jq '.[] | {sha: .sha[0:12], message: .commit.message, date: .commit.author.date, author: .commit.author.name}' | head -60

Length of output: 4925

Correct the commit hash and date - current commit is cleanup code, not the bl3x fix.

The commit date in the comment (Nov 10, 2025) does not match the actual commit date (Oct 3, 2025 — a 37-day discrepancy). Additionally, commit 37a3ea0 ("Remove topad") is cleanup code that removes an unused field; it is not the bl3x handling fix mentioned in the PR objectives.

The actual bl3x fix appears to be commit f157d7b ("amlsblk: Don't assume topad is aligned to file block") from Sep 29, 2025, which contains the bl3x-related padding bug corrections. Verify and use the correct commit hash.

🤖 Prompt for AI Agents 
In extensions/gxlimg.sh around lines 4 to 5, the script references commit
37a3ea072ca81bb3872441a09fe758340fd67dcb with a comment date of Nov 10, 2025,
but that commit is a cleanup ("Remove topad") and the date is incorrect; update
the fetch_from_repo call to use the correct commit that contains the bl3x fix
(f157d7b, commit message "amlsblk: Don't assume topad is aligned to file block")
and set the comment date to the actual commit date (Sep 29, 2025), verifying the
hash against the upstream repo before changing the line.

}

function build_host_tools__compile_gxlimg() {
Expand Down