-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate fabric video to svelte #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
885bc12
initial migration steps
dskamiotis 5267643
refactor onMount with observer
dskamiotis 3a421fc
remove ad.json from legacy template directory
dskamiotis fa4fd96
refactor Fabric component to include video with prop changes to other…
dskamiotis 790317d
refactor props as optional or default undefined to reduce code
dskamiotis d0369e8
remove onmount and keep subscribe
dskamiotis e2b7531
update and refine props
dskamiotis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| <script lang="ts"> | ||
| import type { GAMVariable } from '$lib/gam'; | ||
| import Fabric from '$templates/components/Fabric.svelte'; | ||
|
|
||
| export let Trackingpixel: GAMVariable; | ||
| export let Researchpixel: GAMVariable; | ||
| export let Viewabilitypixel: GAMVariable; | ||
|
|
||
| export let BackgroundScrollType: GAMVariable<'parallax' | 'none' | 'fixed'>; | ||
| export let BackgroundColour: GAMVariable; | ||
|
|
||
| export let BackgroundImage: GAMVariable; | ||
| export let BackgroundImagePosition: GAMVariable; | ||
| export let BackgroundImageRepeat: GAMVariable; | ||
| export let Layer1BackgroundImage: GAMVariable; | ||
| export let Layer1BackgroundPosition: GAMVariable; | ||
| export let Layer2BackgroundImage: GAMVariable; | ||
| export let Layer2BackgroundPosition: GAMVariable; | ||
| export let Layer3BackgroundImage: GAMVariable; | ||
| export let Layer3BackgroundPosition: GAMVariable; | ||
|
|
||
| export let MobileBackgroundImage: GAMVariable; | ||
| export let MobileBackgroundImagePosition: GAMVariable; | ||
| export let MobileBackgroundImageRepeat: GAMVariable; | ||
| export let MobileLayer1BackgroundImage: GAMVariable; | ||
| export let MobileLayer1BackgroundPosition: GAMVariable; | ||
| export let MobileLayer2BackgroundImage: GAMVariable; | ||
| export let MobileLayer2BackgroundPosition: GAMVariable; | ||
| export let MobileLayer3BackgroundImage: GAMVariable; | ||
| export let MobileLayer3BackgroundPosition: GAMVariable; | ||
|
|
||
| export let VideoURL: GAMVariable; | ||
| export let VideoBackupImage: GAMVariable; | ||
| export let MobileVideoBackupImage: GAMVariable; | ||
| export let VideoURLMobile: GAMVariable; | ||
| export let VideoAlignment: GAMVariable; | ||
| </script> | ||
|
|
||
| <Fabric | ||
| TrackingPixel={Trackingpixel} | ||
| ResearchPixel={Researchpixel} | ||
| ViewabilityPixel={Viewabilitypixel} | ||
| {BackgroundScrollType} | ||
| {BackgroundColour} | ||
| {BackgroundImage} | ||
| {BackgroundImagePosition} | ||
| {BackgroundImageRepeat} | ||
| {MobileBackgroundImage} | ||
| {MobileBackgroundImagePosition} | ||
| {MobileBackgroundImageRepeat} | ||
| {Layer1BackgroundImage} | ||
| {Layer1BackgroundPosition} | ||
| {Layer2BackgroundImage} | ||
| {Layer2BackgroundPosition} | ||
| {Layer3BackgroundImage} | ||
| {Layer3BackgroundPosition} | ||
| {MobileLayer1BackgroundImage} | ||
| {MobileLayer1BackgroundPosition} | ||
| {MobileLayer2BackgroundImage} | ||
| {MobileLayer2BackgroundPosition} | ||
| {MobileLayer3BackgroundImage} | ||
| {MobileLayer3BackgroundPosition} | ||
| {VideoURL} | ||
| {VideoBackupImage} | ||
| {MobileVideoBackupImage} | ||
| {VideoURLMobile} | ||
| {VideoAlignment} | ||
| showVideo={true} | ||
| /> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "ClickthroughUrl": "http://www.armani.com/gb/giorgioarmani/women/new-normal_section", | ||
| "BackgroundColour": "transparent", | ||
| "BackgroundImage": "https://tpc.googlesyndication.com/pagead/imgad?id=CICAgKCLn4zhRRABGAEyCNF40kFrzoD3", | ||
| "BackgroundRepeat": "no-repeat", | ||
| "BackgroundPosition": "center center", | ||
| "Layer1BackgroundImage": "https://tpc.googlesyndication.com/pagead/imgad?id=CICAgKCLn4zxIRABGAEyCDODMrRrZ8kQ", | ||
| "Layer1BackgroundPosition": "right top", | ||
| "Layer2BackgroundImage": "https://tpc.googlesyndication.com/pagead/imgad?id=CICAgKCLn4zxIRABGAEyCDODMrRrZ8kQ", | ||
| "Layer2BackgroundPosition": "right top", | ||
| "Layer3BackgroundImage": "", | ||
| "Layer3BackgroundPosition": "left top", | ||
| "MobileBackgroundImage": "", | ||
| "MobileBackgroundRepeat": "no-repeat", | ||
| "MobileBackgroundPosition": "center top", | ||
| "MobileLayer1BackgroundImage": "https://tpc.googlesyndication.com/pagead/imgad?id=CICAgKCLn4zxIRABGAEyCDODMrRrZ8kQ", | ||
| "MobileLayer1BackgroundPosition": "center center", | ||
| "MobileLayer2BackgroundImage": "", | ||
| "MobileLayer2BackgroundPosition": "left top", | ||
| "MobileLayer3BackgroundImage": "", | ||
| "MobileLayer3BackgroundPosition": "left top", | ||
| "VideoURL": "https://player.vimeo.com/external/541626129.hd.mp4?s=e112d0d886a6eaa850b8be46a6369ec710439a1f&profile_id=175", | ||
| "VideoURLMobile": "https://player.vimeo.com/external/541626059.sd.mp4?s=cd36645eeddda5668ddcd6bf524cef0c3ea756eb&profile_id=165", | ||
| "VideoBackupImage": "https://tpc.googlesyndication.com/pagead/imgad?id=CICAgKCLn8ywtAEQARgBMgilQLMRCw4e5A", | ||
| "MobileVideoBackupImage": "", | ||
| "VideoAlignment": "center", | ||
| "Trackingpixel": "", | ||
| "Researchpixel": "", | ||
| "Viewabilitypixel": "", | ||
| "thirdPartyJSTracking": "" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.