Enable TackleTestappPublicBinary analysis

[mguetta1]

Relates to: #329

Summary by CodeRabbit

• Tests

  • Re-enabled a previously skipped test so it now runs.
  • Updated test skip reason links to current GitHub issue references.

• New Features

  • Analysis now runs in dependency-aware mode for more complete results.
  • Expanded analysis tagging to surface broader diagnostic categories.

• Bug Fixes

  • Corrected file-path mappings used in analysis for more accurate insights.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR updates three analyzer test declarations: it changes the SkipTest.Reason URLs in AcmeairWebappBinary and AdministracionEfectivoBinary from Red Hat issue links to GitHub issue URLs; it removes the SkipTest block from TackleTestappPublicBinary, sets WithDeps: true, adjusts two incident file paths, expands and reorders AnalysisTags, and adds the exported field WithDeps to the TC type. No other exported/public signatures were modified.

Possibly related PRs

• Adding option to skip analysis test & skip daytrader in tier0 #309 — Introduced the SkipTest field and related skip-usage patterns that this PR edits (changes to SkipTest.Reason and SkipTest removal).
• Skip binary tests #311 — Edited the same test-case files and skip configurations; overlaps with URL and SkipTest adjustments.
• Enable Daytrader analysis TC and skip binaries #315 — Modifies the same test files and SkipTest-related fields, indicating overlapping code-level changes.

Suggested reviewers

• aufi
• sshveta

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change in the PR: enabling TackleTestappPublicBinary analysis, which is reflected in the removal of SkipTest, addition of WithDeps, and path/tag updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[aufi]

Different tackle-testapp-public binary test results needs to be resolved (it doesn't look as expected results change to me, maybe incorrect scoping of insights&tags for dependencies instead of binary source itself, not sure).

LGTM assuming CI failure is solved.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

analysis/tc_tackle_testapp_public_binary.go (1)

70-86: New Spring/Micrometer tags look good; consider dropping exact duplicates

The additional AnalysisTags for Micrometer/Spring/observability look consistent with existing usage. However, there are several exact duplicates (same Name and Category), e.g. {"Embedded","Spring"}, {"Spring","Embedded"}, and {"Spring","View"} appearing twice each. They’re harmless but can slightly obscure intent or skew any tag-counting logic.

If you want to clean this up, you could remove the redundant entries like this:

-        {Name: "Embedded", Category: api.Ref{Name: "Spring"}},
-        {Name: "Spring", Category: api.Ref{Name: "Embedded"}},
-        {Name: "Spring", Category: api.Ref{Name: "View"}},

leaving a single instance of each (Name, Category) pair.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f0b344 and 7d7b85b.

📒 Files selected for processing (1)

• analysis/tc_tackle_testapp_public_binary.go (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test-tier2 / e2e-api-integration-tests
• GitHub Check: test-tier1 / e2e-api-integration-tests
• GitHub Check: test-tier0 / e2e-api-integration-tests

🔇 Additional comments (3)

analysis/tc_tackle_testapp_public_binary.go (3)

23-23: WithDeps: true aligns with enabling dependency-aware analysis

Setting WithDeps: true on TackleTestappPublicBinary matches the intent to include dependency JARs in the analysis for this binary; the struct literal looks consistent with the rest of the TC usage and raises no concerns.

---

35-35: Confirm Maven cache–based incident path is stable and matches analyzer output

The updated incident File path now points into /cache/m2/.../configuration-utils/1.0.0/.../ApplicationConfiguration.java. Please confirm this exact path is what the analyzer emits in your environment and that /cache/m2 and the 1.0.0 version are stable enough not to cause brittle tests if cache layout or dependency versions change.

---

49-49: Verify persistence.properties path is correct for a binary-only analysis

The incident File path was adjusted to /shared/bin/java-project/src/main/java/persistence.properties, which looks more like a source layout than an exploded WAR path. For a “binary” test case, please double-check that this matches what the analyzer actually reports (and not, for example, a WEB-INF/classes or resources location), to avoid false negatives when assertions run.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

analysis/tc_tackle_testapp_public_binary.go (1)

57-88: Expanded AnalysisTags set is coherent with the app’s Spring/Micrometer stack

The new tags (Micrometer, Spring DI/Boot Actuator/Data JPA/MVC/Web, etc.) and their categories appear consistent and granular, which should improve coverage of what this binary test exercises. I don’t see duplicate (Name, Category) pairs or obvious mis-categorization from this context.

If you expect to grow this list further, you might consider alphabetizing by Name and then Category to keep future diffs easier to scan, but that’s purely cosmetic.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2721b4c and ed9867f.

📒 Files selected for processing (1)

• analysis/tc_tackle_testapp_public_binary.go (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test-tier2 / e2e-api-integration-tests
• GitHub Check: test-tier0 / e2e-api-integration-tests
• GitHub Check: test-tier1 / e2e-api-integration-tests

🔇 Additional comments (2)

analysis/tc_tackle_testapp_public_binary.go (2)

10-24: WithDeps: true aligns with enabling dependency-aware binary analysis

Setting WithDeps: true on this TC alongside Binary: true matches the PR goal of exercising the analyzer with resolved Maven deps, and there’s nothing in this snippet that suggests a misuse of the new field. No issues from this file’s perspective.

---

34-52: Incident file paths look more deterministic; just ensure they match real analyzer output

The updated File values:

• Maven cache path for ApplicationConfiguration.java.
• Source-tree path for persistence.properties instead of a timestamped war-exploded directory.

These should make the expectations more stable and less tied to build timestamps or packaging layout. As long as these strings were captured from a fresh analyzer run with WithDeps enabled, they look good.