WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Enable TackleTestappPublicBinary analysis #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmle merged 7 commits into from
Dec 9, 2025
Merged

Enable TackleTestappPublicBinary analysis #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9b4879d
Enable TackleTestappPublicBinary
mguetta1 Nov 3, 2025
3f7f44d
Merge branch 'main' into enable-binary-tests
mguetta1 Nov 13, 2025
0f0b344
Tackle-testapp binary test must be with deps
jmle Dec 3, 2025
7d7b85b
Fix tests
jmle Dec 3, 2025
2721b4c
Fix tags
jmle Dec 4, 2025
ed9867f
Fix tags
jmle Dec 4, 2025
95fcee4
Merge branch 'main' into enable-binary-tests
mguetta1 Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion analysis/tc_acmeair_webapp_upload_binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

var AcmeairWebappBinary = TC{
SkipTest: SkipTestConfig{
Reason: "Skip binary test. https://issues.redhat.com/browse/MTA-5588",
Reason: "Skip binary test. https://github.com/konveyor/analyzer-lsp/issues/905",
Skip: true,
},
Name: "acmeair-webapp",
Expand Down
2 changes: 1 addition & 1 deletion analysis/tc_administracion_efectivo_upload_binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

var AdministracionEfectivoBinary = TC{
SkipTest: SkipTestConfig{
Reason: "Skip binary test. https://issues.redhat.com/browse/MTA-5588",
Reason: "Skip binary test. https://github.com/konveyor/analyzer-lsp/issues/906",
Skip: true,
},
Name: "administracion-efectivo",
Expand Down
33 changes: 24 additions & 9 deletions analysis/tc_tackle_testapp_public_binary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import (
)

var TackleTestappPublicBinary = TC{
SkipTest: SkipTestConfig{
Reason: "Skip binary test. https://issues.redhat.com/browse/MTA-5588",
Skip: true,
},
Name: "tackle-testapp-binary",
Application: data.TackleTestappPublicBinary,
Identities: []api.Identity{
Expand All @@ -24,6 +20,7 @@ var TackleTestappPublicBinary = TC{
},
},
Binary: true,
WithDeps: true,
Analysis: api.Analysis{
Effort: 2,
Insights: []api.Insight{
Expand All @@ -35,7 +32,7 @@ var TackleTestappPublicBinary = TC{
Rule: "local-storage-00001",
Incidents: []api.Incident{
{
File: "/shared/bin/java-project/src/main/java/io/konveyor/demo/config/ApplicationConfiguration.java",
File: "/cache/m2/io/konveyor/demo/configuration-utils/1.0.0/io/konveyor/demo/config/ApplicationConfiguration.java",
Line: 14,
Message: "An application running inside a container could lose access to a file in local storage.",
},
Expand All @@ -49,7 +46,7 @@ var TackleTestappPublicBinary = TC{
Rule: "hardcoded-ip-address",
Incidents: []api.Incident{
{
File: "/shared/bin/java-project/customers-tomcat-0-0-1-20240913-093117-1-war-exploded/WEB-INF/classes/persistence.properties",
File: "/shared/bin/java-project/src/main/java/persistence.properties",
Line: 2,
Message: "When migrating environments, hard-coded IP addresses may need to be modified or eliminated.",
},
Expand All @@ -59,16 +56,34 @@ var TackleTestappPublicBinary = TC{
},
AnalysisTags: []api.Tag{
{Name: "EJB XML", Category: api.Ref{Name: "Bean"}},
{Name: "Servlet", Category: api.Ref{Name: "HTTP"}},
{Name: "JPA named queries", Category: api.Ref{Name: "Persistence"}},
{Name: "EJB XML", Category: api.Ref{Name: "Connect"}},
{Name: "EJB XML", Category: api.Ref{Name: "Java EE"}},
{Name: "JPA named queries", Category: api.Ref{Name: "Java EE"}},
{Name: "Servlet", Category: api.Ref{Name: "HTTP"}},
{Name: "Servlet", Category: api.Ref{Name: "Java EE"}},
{Name: "Servlet", Category: api.Ref{Name: "Connect"}},
{Name: "JPA named queries", Category: api.Ref{Name: "Persistence"}},
{Name: "JPA named queries", Category: api.Ref{Name: "Java EE"}},
{Name: "JPA named queries", Category: api.Ref{Name: "Store"}},
{Name: "Properties", Category: api.Ref{Name: "Embedded"}},
{Name: "Properties", Category: api.Ref{Name: "Other"}},
{Name: "Properties", Category: api.Ref{Name: "Sustain"}},
{Name: "Micrometer", Category: api.Ref{Name: "Embedded"}},
{Name: "Micrometer", Category: api.Ref{Name: "Execute"}},
{Name: "Micrometer", Category: api.Ref{Name: "Integration"}},
{Name: "Spring DI", Category: api.Ref{Name: "Embedded"}},
{Name: "Spring DI", Category: api.Ref{Name: "Execute"}},
{Name: "Spring DI", Category: api.Ref{Name: "Inversion of Control"}},
{Name: "Spring Boot Actuator", Category: api.Ref{Name: "Embedded"}},
{Name: "Spring Boot Actuator", Category: api.Ref{Name: "Observability"}},
{Name: "Spring Boot Actuator", Category: api.Ref{Name: "Sustain"}},
{Name: "Spring Data JPA", Category: api.Ref{Name: "Persistence"}},
{Name: "Spring Data JPA", Category: api.Ref{Name: "Store"}},
{Name: "Spring Data JPA", Category: api.Ref{Name: "Embedded"}},
{Name: "Spring MVC", Category: api.Ref{Name: "Embedded"}},
{Name: "Spring MVC", Category: api.Ref{Name: "MVC"}},
{Name: "Spring MVC", Category: api.Ref{Name: "View"}},
{Name: "Spring Web", Category: api.Ref{Name: "Embedded"}},
{Name: "Spring Web", Category: api.Ref{Name: "View"}},
{Name: "Spring Web", Category: api.Ref{Name: "Web"}},
},
}
Loading