WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Nov 25, 2025

Description

This PR implements changes needed to build successfully with CCCL 3.2.

I added a device_memory_resource_view class, updated RMM's resource_ref adaptors for CCCL types to retain device_memory_resource* constructors, and fixed a variety of small issues that arise with the new memory resource design.

Part of #2143.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Nov 25, 2025
@bdice bdice moved this to In Progress in RMM Project Board Nov 25, 2025
@bdice bdice added feature request New feature or request breaking Breaking change labels Nov 25, 2025
@bdice bdice mentioned this pull request Nov 25, 2025
3 tasks
@bdice bdice requested a review from PointKernel November 26, 2025 03:30
@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2025

/merge

@rapids-bot rapids-bot bot merged commit 1ef8002 into rapidsai:main Nov 26, 2025
79 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in RMM Project Board Nov 26, 2025
@bdice bdice mentioned this pull request Nov 26, 2025
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Nov 26, 2025
CI is failing in libcudf. I missed committing some local changes that were meant to go into #2162.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)

URL: #2166
bdice added a commit to bdice/rmm that referenced this pull request Nov 27, 2025
@bdice bdice mentioned this pull request Nov 27, 2025
rapids-bot bot pushed a commit that referenced this pull request Nov 27, 2025
- Revert "Fix device_memory_resource_view. (#2166)"
- Revert "Compatibility updates for CCCL 3.2 (#2162)"

This unblocks some build failures observed in RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)

URL: #2167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change feature request New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants